Skip to content

Allow Eclipse 4 contributions to select svg files via the find dialog#1721

Merged
vogella merged 2 commits intoeclipse-pde:masterfrom
vogella:pr-1580
Apr 15, 2025
Merged

Allow Eclipse 4 contributions to select svg files via the find dialog#1721
vogella merged 2 commits intoeclipse-pde:masterfrom
vogella:pr-1580

Conversation

@vogella
Copy link
Copy Markdown
Contributor

@vogella vogella commented Apr 15, 2025

With the svg support in SWT we should also allow the selection of svg files for Eclipse 4 application model elements.

Fixes #eclipse-platform/eclipse.platform.ui#2911

@vogella
Allow Eclipse 4 contributions to select svg files via the find dialog
5724095 
With the svg support in SWT we should also allow the selection of svg
files for Eclipse 4 application model elements.

Fixes #eclipse-platform/eclipse.platform.ui#2911
@vogella vogella mentioned this pull request Apr 15, 2025
Closed
@eclipse-pde-bot
Copy link
Copy Markdown
Contributor

eclipse-pde-bot commented Apr 15, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

e4tools/bundles/org.eclipse.e4.tools.emf.ui/META-INF/MANIFEST.MF
e4tools/bundles/org.eclipse.e4.tools.emf.ui/pom.xml
features/org.eclipse.e4.core.tools.feature/feature.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch 
From ba537858d9331d9f4064acee04c70965e61b995c Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <pde-bot@eclipse.org>
Date: Tue, 15 Apr 2025 17:18:15 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/e4tools/bundles/org.eclipse.e4.tools.emf.ui/META-INF/MANIFEST.MF b/e4tools/bundles/org.eclipse.e4.tools.emf.ui/META-INF/MANIFEST.MF
index a476ca2a24..0bf31b355b 100644
--- a/e4tools/bundles/org.eclipse.e4.tools.emf.ui/META-INF/MANIFEST.MF
+++ b/e4tools/bundles/org.eclipse.e4.tools.emf.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.e4.tools.emf.ui;singleton:=true
-Bundle-Version: 4.8.600.qualifier
+Bundle-Version: 4.8.700.qualifier
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
 Bundle-RequiredExecutionEnvironment: JavaSE-17
diff --git a/e4tools/bundles/org.eclipse.e4.tools.emf.ui/pom.xml b/e4tools/bundles/org.eclipse.e4.tools.emf.ui/pom.xml
index 02dd8c4511..8b19e9c842 100644
--- a/e4tools/bundles/org.eclipse.e4.tools.emf.ui/pom.xml
+++ b/e4tools/bundles/org.eclipse.e4.tools.emf.ui/pom.xml
@@ -21,7 +21,7 @@
 
   <groupId>org.eclipse.platform</groupId>
   <artifactId>org.eclipse.e4.tools.emf.ui</artifactId>
-  <version>4.8.600-SNAPSHOT</version>
+  <version>4.8.700-SNAPSHOT</version>
   <packaging>eclipse-plugin</packaging>
 
   <properties>
diff --git a/features/org.eclipse.e4.core.tools.feature/feature.xml b/features/org.eclipse.e4.core.tools.feature/feature.xml
index fe474fda39..0c8735ca5b 100644
--- a/features/org.eclipse.e4.core.tools.feature/feature.xml
+++ b/features/org.eclipse.e4.core.tools.feature/feature.xml
@@ -2,7 +2,7 @@
 <feature
       id="org.eclipse.e4.core.tools.feature"
       label="%featureName"
-      version="4.30.400.qualifier"
+      version="4.30.500.qualifier"
       provider-name="%providerName"
       license-feature="org.eclipse.license"
       license-feature-version="0.0.0">
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 15, 2025

Test Results

   285 files  +  6     285 suites  +6   56m 52s ⏱️ + 5m 31s
 3 608 tests ±  0   3 532 ✅ +  1   76 💤 ± 0  0 ❌  - 1 
11 016 runs  +194  10 785 ✅ +166  231 💤 +29  0 ❌  - 1 

Results for commit 4dab277. ± Comparison against base commit b2b12f1.

@vogella vogella merged commit e63f3f9 into eclipse-pde:master Apr 15, 2025
19 checks passed
@vogella vogella deleted the pr-1580 branch April 15, 2025 17:56
@vogella
Copy link
Copy Markdown
Contributor Author

vogella commented Apr 15, 2025

@HannesWell I know its been a while since you created it, but your version update tool is still amazing

@merks
Copy link
Copy Markdown
Contributor

merks commented Apr 15, 2025

Yes it’s really great. Plus @laeubi’s cleanups and tp updater. These guys make things that streamline our work. 🥇

@HannesWell
Copy link
Copy Markdown
Member

HannesWell commented Apr 16, 2025

@HannesWell I know its been a while since you created it, but your version update tool is still amazing

Thank you and thank you for this contribution.

@vogella
Copy link
Copy Markdown
Contributor Author

vogella commented Apr 17, 2025

Yes it’s really great. Plus @laeubi’s cleanups and tp updater. These guys make things that streamline our work. 🥇

Thanks for pointing this out @merks . I agree that @laeubi clean-up automation is also amazing, especially since @jjohnstn continues to improve and fix the JDT clean-ups. Together with the Github build action validation the current automation of the work is outstanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vogella @eclipse-pde-bot @merks @HannesWell